Fix incomplete computed property deoptimization #3267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #3264
Description
I am aware that #3266 already provides a fix for #3264 and I hope there is no ill thought from the author (the other fix in the PR is still welcome), but this PR will actually fix the root cause of the issue, which is that when the key of a computed property is later deoptimized, and the involved member expression had a deoptimized path, then ALL paths of the member expression need to be deoptimized (I know this may sound VERY confusing. I really hope to find some time soon to improve the names of the concepts around this).
So the result is that
is completely retained, while
is correctly optimized to